Uploaded image for project: 'ROOT'
  1. ROOT
  2. ROOT-10477

RHistImpl::GetBinUncertainty is not consistent with GetBinContent

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open (View Workflow)
    • Priority: Low
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Core Libraries
    • Labels:
    • Environment:

      Issue is in the source code, environment does not come into play.

    • Development:

      Description

      As of today's master, RHistImpl::GetBinUncertainty and RHistImpl::GetBinContent are implemented rather differently:

      • One is partially implemented at the RHistImplBase layer, the other is fully implemented at the RHistImpl layer.
      • One is checking that GetBinIndex returns a positive bin index (where a negative index seems to indicate a bin lookup error), the other doesn't.

      The former inconsistency merely makes the code harder to read, the latter inconsistency is probably an error handling bug. Overall, it seems a bit of implementation homogeneization wouldn't hurt there.

        Attachments

          Activity

            People

            Assignee:
            axel Axel Naumann
            Reporter:
            hgraslan Hadrien Benjamin Grasland
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: