Uploaded image for project: 'ROOT'
  1. ROOT
  2. ROOT-2558

SPlot crashes when yields are not the top level fitparameters

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: < v5-28-00
    • Fix Version/s: 6.22/00
    • Component/s: RooFit/RooStats
    • Labels:
      None
    • Environment:

      GNU/Linux

      Description

      Hi,
      When using the sPlot class it seems to be mandatory that the yields are RooRealVars and the fit Parameters. Using a Model like:
      RooRealVar ratio(&quot;xsec ratio&quot;,&quot;&quot;,1,0,10);
      RooRealVar yield_sm(&quot;yield_sm&quot;,&quot;&quot;,100);
      RooFormulaVar Ns(&quot;Signal Yield&quot;,&quot;&quot;,&quot;@0*@1&quot;,RooArgSet(ratio,yield_sm));

      causes a crash:
      1 INFO:Minization -- RooMinuit::optimizeConst: deactivating const optimization
      1) 0x8a18b88 RooFormulaVar:: nsig[ actualVars=(nsig_const,sig_ratio,lumi) formula=&quot;@0*@1*@2&quot; ] = 160.748 &quot;@0*@1*@2&quot;
      2) 0x8a19200 RooFormulaVar:: nbkg1[ actualVars=(nbkg1_const,bkg_scale,lumi) formula=&quot;@0*@1*@2&quot; ] = 5275.91 &quot;@0*@1*@2&quot;
      3) 0x8a19878 RooFormulaVar:: nbkg2[ actualVars=(nbkg2_const,bkg_scale,lumi) formula=&quot;@0*@1*@2&quot; ] = 16498.5 &quot;@0*@1*@2&quot;
      4) 0x8a19ef0 RooFormulaVar:: nbkg3[ actualVars=(nbkg3_const,bkg_scale,lumi) formula=&quot;@0*@1*@2&quot; ] = 3774.23 &quot;@0*@1*@2&quot;
      5) 0x8a1a568 RooFormulaVar:: nbkg4[ actualVars=(nbkg4_const,bkg_scale,lumi) formula=&quot;@0*@1*@2&quot; ] = 8649.69 &quot;@0*@1*@2&quot;
      1 INFO:NumericIntegration -- RooRealIntegral::init(hgg_pt_sig_landau_Int[ptVtx]) using numeric integrator RooIntegrator1D to calculate Int(ptVtx)
      1 INFO:NumericIntegration -- RooRealIntegral::init(hgg_pt_bkg4_landau_Int[ptVtx]) using numeric integrator RooIntegrator1D to calculate Int(ptVtx)
      EIGENVALUES OF SECOND-DERIVATIVE MATRIX:

      MINUIT WARNING IN HESSE
      ============== MATRIX FORCED POS-DEF BY ADDING 0.001000 TO DIAGONAL.
      MINUIT WARNING IN HESSE
      ============== Matrix inversion fails.
      1 INFO:Minization -- RooFitResult::fillCorrMatrix: number of floating parameters is zero, correlation matrix not filled
      1 INFO:Fitting -- RooAbsPdf::fitTo(model) Calculating sum-of-weights-squared correction matrix for covariance matrix
      EIGENVALUES OF SECOND-DERIVATIVE MATRIX:

      MINUIT WARNING IN HESSE
      ============== MATRIX FORCED POS-DEF BY ADDING 0.001000 TO DIAGONAL.
      MINUIT WARNING IN HESSE
      ============== Matrix inversion fails.
      1 INFO:Minization -- RooFitResult::fillCorrMatrix: number of floating parameters is zero, correlation matrix not filled

          • Break *** segmentation violation
            Using host libthread_db library &quot;/lib64/tls/libthread_db.so.1&quot;.
            Attaching to program: /proc/334/exe, process 334
            [Thread debugging using libthread_db enabled]
            [New Thread 4107560640 (LWP 334)]
            0xffffe410 in __kernel_vsyscall ()
            #1 0x00b7d4b3 in __waitpid_nocancel () from /lib/tls/libc.so.6
            #2 0x00b26779 in do_system () from /lib/tls/libc.so.6
            #3 0x00c5998d in system () from /lib/tls/libpthread.so.0
            #4 0xf7b623af in TUnixSystem::Exec ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libCore.so
            #5 0xf7b68047 in TUnixSystem::StackTrace ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libCore.so
            #6 0xf7b64a42 in TUnixSystem::DispatchSignals ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libCore.so
            #7 0xf7b64ad0 in SigHandler ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libCore.so
            #8 0xf7b63d4d in sighandler ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libCore.so
            #9 &lt;signal handler called&gt;
            #10 0xf7aade4e in TObject::TObject$base ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libCore.so
            #11 0xf6630e7e in TMatrixTSym&lt;double&gt;::TMatrixTSym ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libMatrix.so
            #12 0xf5ae2709 in RooAbsPdf::fitTo ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libRooFitCore.so
            #13 0xf5ada06b in RooAbsPdf::fitTo ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libRooFitCore.so
            #14 0xf55335d0 in RooStats::SPlot::AddSWeight ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libRooStats.so
            #15 0xf5535637 in RooStats::SPlot::SPlot ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libRooStats.so
            #16 0x08052920 in sPlot ()
            at /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/include/TObject.h:156
            #17 0x08052ed9 in main (argc=3, argv=0xffffca54) at makeyyPlots.cxx:116
          • glibc detected *** corrupted double-linked list: 0x08f974b8 *** *** Break *** segmentation violation
            Using host libthread_db library &quot;/lib64/tls/libthread_db.so.1&quot;.
            Attaching to program: /proc/334/exe, process 334
            [Thread debugging using libthread_db enabled]
            [New Thread 4107560640 (LWP 334)]
            0xffffe410 in __kernel_vsyscall ()
            #1 0x00b7d4b3 in __waitpid_nocancel () from /lib/tls/libc.so.6
            #2 0x00b26779 in do_system () from /lib/tls/libc.so.6
            #3 0x00c5998d in system () from /lib/tls/libpthread.so.0
            #4 0xf7b623af in TUnixSystem::Exec ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libCore.so
            #5 0xf7b68047 in TUnixSystem::StackTrace ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libCore.so
            #6 0xf7b64a42 in TUnixSystem::DispatchSignals ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libCore.so
            #7 0xf7b64ad0 in SigHandler ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libCore.so
            #8 0xf7b63d4d in sighandler ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libCore.so
            #9 &lt;signal handler called&gt;
            #10 0xf7aade4e in TObject::TObject$base ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libCore.so
            #11 0xf6630e7e in TMatrixTSym&lt;double&gt;::TMatrixTSym ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libMatrix.so
            #12 0xf5ae2709 in RooAbsPdf::fitTo ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libRooFitCore.so
            #13 0xf5ada06b in RooAbsPdf::fitTo ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libRooFitCore.so
            #14 0xf55335d0 in RooStats::SPlot::AddSWeight ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libRooStats.so
            #15 0xf5535637 in RooStats::SPlot::SPlot ()
            from /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/lib/libRooStats.so
            #16 0x08052920 in sPlot ()
            at /afs/cern.ch/user/r/ruthmann/scratch0/programs/root-dev/include/TObject.h:156
            #17 0x08052ed9 in main (argc=3, argv=0xffffca54) at makeyyPlots.cxx:116
          • glibc detected *** corrupted double-linked list: 0x08f974b8 ***

      would be nice to have this working since ratios are more convenient to use.
      regards, Nils

        Attachments

          Activity

            People

            • Assignee:
              shageboe Stephan Hageboeck
              Reporter:
              ruthmann Nils Ruthmann (Inactive)
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: