Uploaded image for project: 'ROOT'
  1. ROOT
  2. ROOT-7401

Define ROOT_XXX_FLAGS in ROOTConfig.cmake for use by client packages

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed (View Workflow)
    • High
    • Resolution: Fixed
    • 6.04.00, 5.34/28
    • None
    • Build System
    • None

    Description

      Federico: I have a small correction to suggest to the ROOT cmake. You should never add compiler flags to definitions because these are applied to all compilers. I have a small project with some Fortran and there is NO way to avoid all the C++ flags to be added to Fortran compilation, which fails mercilessly. I am proposing the following patch, which works for me. Thanks for considering it.

      Pere: I think I will use the occasion to do a proper job. I think we need to define a bunch of variables: ROOT_CXX_FLAGS, ROOT_C_FLAGS, ROOT_Fortran_FLAGS and ROOT_DEFINITIONS. And then in the RootUseFile.cmake do to the proper thing of adding them into the adequate CMAKE_XX_FLAGS and add_defintions().

      Attachments

        Activity

          People

            mato Pere Mato Vila
            carminat Federico Carminati (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: