Uploaded image for project: 'ROOT'
  1. ROOT
  2. ROOT-8167

OpenExcessFiles return value ignored in TFileMerger::PartialMerge

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Medium
    • Resolution: Fixed
    • Affects Version/s: 5.34/36
    • Fix Version/s: 6.08/00, 5.34/38
    • Component/s: I/O
    • Labels:
      None
    • Environment:

      SLF7

      Description

      TFileMerger::PartialMerge should return kTrue if the merge is successful. If there are > fMaxOpenedFiles in the merge set, and opening of any excess file fails, PartialMerge will abort early but still return true.

      Suggest altering line 852 of TFileMerger.cxx to read

        if(!OpenExcessFiles()) return kFalse;

        Attachments

          Activity

            People

            • Assignee:
              pcanal Philippe Canal
              Reporter:
              e6d9bd090bb7464e72d1 Ben Loer
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: