Uploaded image for project: 'ROOT'
  1. ROOT
  2. ROOT-8207

tmva/tmva/CMakeLists.txt unnecessarily includes TreeViewer

    XMLWordPrintable

Details

    Description

      libTMVA.so built with cmake has a dependency on TreeViewer that isn't present in the library built with ./configure && make. This is unfortunate as TreeViewer pulls in libGui, which does things in static constructors that cause problems for GRID jobs, see this CMS hn thread for details:

      https://hypernews.cern.ch/HyperNews/CMS/get/edmFramework/3654.html

      TMVA only needs TreePlayer, not TreeViewer, so the tmva CMakeLists.txt should be changed accordingly:

      --- tmva/tmva/CMakeLists.txt~	2016-03-03 04:36:03.000000000 -0500
      +++ tmva/tmva/CMakeLists.txt	2016-05-27 12:27:57.756294152 -0400
      @@ -46,7 +46,7 @@
       ROOT_GENERATE_DICTIONARY(G__TMVA ${theaders1} ${theaders2} ${theaders3} ${theaders4}   MODULE TMVA LINKDEF LinkDef.h OPTIONS "-writeEmptyRootPCM")
       
       ROOT_LINKER_LIBRARY(TMVA *.cxx G__TMVA.cxx LIBRARIES Core
      -                    DEPENDENCIES RIO Hist Tree TreeViewer  MLP Minuit XMLIO)
      +                    DEPENDENCIES RIO Hist Tree TreePlayer  MLP Minuit XMLIO)
       
       install(DIRECTORY inc/TMVA/ DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/TMVA
                                   COMPONENT headers

      Attachments

        Activity

          People

            mato Pere Mato Vila
            dsr Daniel Sherman Riley
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:
              Actual End: