Uploaded image for project: 'ROOT'
  1. ROOT
  2. ROOT-8692

make install: python files are not compiled correctly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.10/00
    • Component/s: Build System
    • Labels:
      None
    • Environment:

      Arch Linux x86_64

    • Development:

      Description

      This is how I compile and make install ROOT:

        cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo \
              -DCMAKE_INSTALL_PREFIX=/opt/root/6.09.01.1680.gf25179505b \
              -Dall=ON \
              -DPYTHON_EXECUTABLE=/usr/bin/python2.7 \
              -DPYTHON_INCLUDE_DIR=/usr/include/python2.7 \
              -DPYTHON_LIBRARY=/usr/lib/libpython2.7.so \
              ../root
        make
        make DESTDIR=$pkgdir install

      where $pkgdir contains the path to the location used for packaging (this is from an ArchLinux PKGBUILD script).

      make install produces these errors:

      -- Installing: /home/beischer/abs/root6-icc/pkg/root6-icc/opt/root/6.09.01.1680.gf25179505b-icc/lib/cmdLineUtils.py
      Traceback (most recent call last):
        File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
          "__main__", fname, loader, pkg_name)
        File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
          exec code in run_globals
        File "/usr/lib/python2.7/py_compile.py", line 170, in <module>
          sys.exit(main())
        File "/usr/lib/python2.7/py_compile.py", line 162, in main
          compile(filename, doraise=True)
        File "/usr/lib/python2.7/py_compile.py", line 106, in compile
          with open(file, 'U') as f:
      IOError: [Errno 2] No such file or directory: '/home/beischer/abs/root6-icc/pkg/root6-icclib/cmdLineUtils.py'
      Traceback (most recent call last):
        File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
          "__main__", fname, loader, pkg_name)
        File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
          exec code in run_globals
        File "/usr/lib/python2.7/py_compile.py", line 170, in <module>
          sys.exit(main())
        File "/usr/lib/python2.7/py_compile.py", line 162, in main
          compile(filename, doraise=True)
        File "/usr/lib/python2.7/py_compile.py", line 106, in compile
          with open(file, 'U') as f:
      IOError: [Errno 2] No such file or directory: '/home/beischer/abs/root6-icc/pkg/root6-icclib/cmdLineUtils.py'

      DESTDIR is == /home/beischer/abs/root6-icc/pkg/root6-icc

      I assume the breakage results from this commit:

      commit 148de19bb93fc61e372cb79288f369c98496e5e4
      Author: Mattias Ellert <mattias.ellert@fysast.uu.se>
      Date:   Wed Jul 27 06:19:46 2016 +0200
       
          Fix paths
       
      diff --git a/bindings/pyroot/CMakeLists.txt b/bindings/pyroot/CMakeLists.txt
      index 40883a748d..157b79c932 100644
      --- a/bindings/pyroot/CMakeLists.txt
      +++ b/bindings/pyroot/CMakeLists.txt
      @@ -37,8 +37,8 @@ endif()
       file(GLOB pyfiles RELATIVE ${CMAKE_CURRENT_SOURCE_DIR} *.py)
       foreach(pyfile ${pyfiles})
         install(FILES ${pyfile} DESTINATION ${runtimedir})
      -  install(CODE "execute_process(COMMAND python -m py_compile \$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${runtimedir}/${pyfile} )")
      -  install(CODE "execute_process(COMMAND python -O -m py_compile \$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${runtimedir}/${pyfile} )")
      +  install(CODE "execute_process(COMMAND python -m py_compile \$ENV{DESTDIR}${runtimedir}/${pyfile})")
      +  install(CODE "execute_process(COMMAND python -O -m py_compile \$ENV{DESTDIR}${runtimedir}/${pyfile})")
         file(COPY ${pyfile} DESTINATION ${localruntimedir})
       endforeach()
       
      diff --git a/main/CMakeLists.txt b/main/CMakeLists.txt
      index 591798d21d..d5c624cf66 100644
      --- a/main/CMakeLists.txt
      +++ b/main/CMakeLists.txt
      @@ -40,7 +40,7 @@ if(python)
         endforeach()
       
         install(FILES python/cmdLineUtils.py DESTINATION ${runtimedir})
      -  install(CODE "execute_process(COMMAND ${PYTHON_EXECUTABLE} -m py_compile \$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${runtimedir}/cmdLineUtils.py )")
      -  install(CODE "execute_process(COMMAND ${PYTHON_EXECUTABLE} -O -m py_compile \$ENV{DESTDIR}\${CMAKE_INSTALL_PREFIX}/${runtimedir}/cmdLineUtils.py )")
      +  install(CODE "execute_process(COMMAND ${PYTHON_EXECUTABLE} -m py_compile \$ENV{DESTDIR}${runtimedir}/cmdLineUtils.py)")
      +  install(CODE "execute_process(COMMAND ${PYTHON_EXECUTABLE} -O -m py_compile \$ENV{DESTDIR}${runtimedir}/cmdLineUtils.py)")
         configure_file(python/cmdLineUtils.py ${localruntimedir}/cmdLineUtils.py @ONLY)
       endif()

      the new paths seem wrong.

        Attachments

          Activity

            People

            • Assignee:
              mato Pere Mato Vila
              Reporter:
              bbeische Bastian Beischer
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Actual End: