Uploaded image for project: 'ROOT'
  1. ROOT
  2. ROOT-9231

TMVA GUI produces identical results for variants of models used in RMVA

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Low
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.13/03
    • Component/s: TMVA
    • Labels:
      None
    • Environment:

      All environments

    • Development:

      Description

      Models trained with RMVA are saved in .Rdata files.
      For all of the models in 
      MethodC50.cxx 
      MethodRSNNS.cxx 
      MethodRSVM.cxx 
      MethodRXGB.cxx 

      name of the file is hardcoded e.g:

      TString path = GetWeightFileDir() + "/RXGBModel.RData";

      so when one books multiple variations of the same model with

      factory->BookMethod(dataloader, TMVA::Types::kRXGB, "kRXGB", "!V:NRounds=80:MaxDepth=2:Eta=1");

      TMVA keeps overwriting the same file and at the end reports the same results for all variants.

      An easy fix which I tested to be working is to replace the lines like

      TString path = GetWeightFileDir() + "/RXGBModel.RData

      with

      TString path = GetWeightFileDir() + "/" + GetName() + ".RData";

      everywhere in *.cxx files above. This will use a file name based on the method title the same way it is done for the default TMVA methods as long as a user uses unique titles when booking using the line above

        Attachments

          Activity

            People

            Assignee:
            moneta Lorenzo Moneta
            Reporter:
            ypetrov Yevgeniy Petrov
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: