Uploaded image for project: 'ROOT'
  1. ROOT
  2. ROOT-9419

Incorrect RooAddPdf parameter value when convoluting via RooFFTConvPdf

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • High
    • Resolution: Ready for test
    • 6.11/02
    • 6.18/00
    • RooFit/RooStats
    • None
    • macOS High Sierra¬†10.13.3
      ROOT 6.11/02
      RooFit v3.60

    Description

      Reposting the ROOT forum topic here since we did not get any feedback on it.

      The attached code demonstrates incorrect calculation of RooAddPdf parameter value when fitting data with a sum of two RooAbsPdf's (exponential decays) convoluted with a RooGaussian via RooFFTConvPdf.

      In order to reveal the problem we fit the same dataset by means of RooDecay's convoluted with RooGaussModel and obtain different intensity of exponential component.

      Both fits are plotted on the same canvas here. Image clearly demonstrates the notable discrepancy between fractions of exponential decays. Other model parameters as well as fit curves look identical.

      Another piece of the puzzle might be this post:

      Commutativity of FFT-ed PDFs

      Attachments

        1. canvas.png
          canvas.png
          110 kB
        2. convtest.zip
          10 kB

        Issue Links

          Activity

            People

              shageboe Stephan Hageboeck
              d99e3f1438a7a0715f14 Petr Stepanov (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                Actual Start:
                Actual End: