[ROOT-5294] TEveBrowser::MakeFileBrowser doesn't set fFileBrowser Created: 18/Jun/13  Updated: 15/May/19  Resolved: 27/Jun/13

Status: Closed
Project: ROOT
Component/s: GUI
Affects Version/s: 5.34/00
Fix Version/s: None

Type: Bug Priority: Medium
Reporter: Christian Pulvermacher Assignee: Matevz Tadel
Resolution: Fixed Votes: 0
Labels: None


Actual End:


As a result, GetFileBrowser() might still return NULL after calling MakeFileBrowser(), which is a bit confusing.

Comment by Bertrand Bellenot [ 20/Jun/13 ]

I agree, this may be a bit confusing. This is easy to fix, but I'll let Matevz doing it (as I don't know if it was done on purpose...) Thanks for the report.
Cheers, Bertrand.

Comment by Matevz Tadel [ 20/Jun/13 ]


Looking at the code and trying to remember ... I think the idea was that one could create several file browsers and have them set on different directories etc. The InitPlugins does set fFileBrowser when creted with "F" as this is expected to be THE browser.

How about adding SetFileBrowser() so that one can do SetFileBrowser(MakeFileBrowser()) or adding a bool flag to MakeFileBrowser(Bool_t make_default=kFALSE)? We can as well add both I vote for that.

What do you say?


PS: I'm ashamed of myself but I haven't started with git yet ... things are just too crazy for me these days So, expect me to screw up the whole repository when I try to commit and merge this.

Comment by Christian Pulvermacher [ 21/Jun/13 ]

Yeah, that would make it consistent ¿ although I'd suggest adding something like "returns default file manager" to the documentation.

Thanks again,

(If something goes wrong, just call it a repository stress-test? )

Comment by Matevz Tadel [ 27/Jun/13 ]

This is now committed on 5.34-patches ... I still have to figure out how to:
1. merge this onto trunk;
2. mark the thing closed/done in bloody jira.

I must be getting old or sth ... I'm annoyed by svn->git and savannah->jira thingy


Generated at Mon Feb 17 07:18:03 CET 2020 using Jira 8.3.4#803005-sha1:1f96e09b3c60279a408a2ae47be3c745f571388b.